Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18772] Rename AesCbc256 to Aes256Cbc #13637

Draft
wants to merge 1 commit into
base: km/refactor-symmetric-keys-3
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Feb 28, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-18697
https://bitwarden.atlassian.net/browse/PM-18772

This is a follow-up PR to:
#13578
#13598
#13599

Corresponding SDK pr: bitwarden/sdk-internal#172

๐Ÿ“” Objective

Currently we use: Aes256Cbc, but also AesCbc256 in the SDK. In the web clients we use AesCbc256. In general the former order is more common.
For instance, TLS defines: TLS_DHE_RSA_WITH_AES_256_CBC_SHA384. JWK defines: AES_128_CBC_HMAC_SHA_256, SSH defines aes256-cbc, COSE defines: A256CBC.
This is because the block cipher is: AES-128-Bit / AES-256-Bit, and the mode of operation is CBC. Semantically, we are currently splitting up the block cipher used and interjecting the mode of operation in the middle.
This PR renames the instances used in the SDK of AesCbc256 to be consistent with other standards, and to be consistent within our codebase. There will be a corresponding PR for the web clients (this is in draft until then).

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 1b4d7128-b231-4e6d-b18d-dab1d50a9514

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Missing_HSTS_Header /apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.ts: 116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant