[PM-18772] Rename AesCbc256 to Aes256Cbc #172
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18772
Clients bitwarden/clients#13637
📔 Objective
Currently we use:
Aes256Cbc
, but alsoAesCbc256
in the SDK. In the web clients we useAesCbc256
. In general the former order is more common.For instance, TLS defines:
TLS_DHE_RSA_WITH_AES_256_CBC_SHA384
. JWK defines:AES_128_CBC_HMAC_SHA_256
, SSH definesaes256-cbc
, COSE defines:A256CBC
.This is because the block cipher is: AES-128-Bit / AES-256-Bit, and the mode of operation is
CBC
. Semantically, we are currently splitting up the block cipher used and interjecting the mode of operation in the middle.This PR renames the instances used in the SDK of
AesCbc256
to be consistent with other standards, and to be consistent within our codebase. There will be a corresponding PR for the web clients (this is in draft until then).⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes