Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update at-since up to and including 2.226 #4587

Merged
merged 2 commits into from
Mar 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/EnvVars.java
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ public void putIfNotNull(String key, String value) {

/**
* Add entire map but filter null values out.
* @since TODO
* @since 2.214
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4194 (still a pointless change without merit).

*/
public void putAllNonNull(Map<String, String> map) {
map.forEach(this::putIfNotNull);
Expand Down
8 changes: 4 additions & 4 deletions core/src/main/java/hudson/Functions.java
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ public static String getSystemProperty(String key) {
/**
* Returns true if and only if the UI refresh is enabled.
*
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@Restricted(DoNotUse.class)
public static boolean isUiRefreshEnabled() {
Expand Down Expand Up @@ -1099,7 +1099,7 @@ public static Collection<Descriptor> getSortedDescriptorsForGlobalConfig(com.goo
*
* @param predicate
* Filter the descriptors based on this predicate
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static Collection<Descriptor> getSortedDescriptorsForGlobalConfigByDescriptor(Predicate<Descriptor> predicate) {
ExtensionList<Descriptor> exts = ExtensionList.lookup(Descriptor.class);
Expand Down Expand Up @@ -1148,7 +1148,7 @@ public static Collection<Descriptor> getSortedDescriptorsForGlobalConfigUnclassi
/**
* Descriptors shown in the global configuration form to users with {@link Jenkins#SYSTEM_READ} permission.
*
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@Restricted(NoExternalUse.class)
public static Collection<Descriptor> getSortedDescriptorsForGlobalConfigUnclassifiedReadable() {
Expand All @@ -1162,7 +1162,7 @@ public static Collection<Descriptor> getSortedDescriptorsForGlobalConfigUnclassi
* @throws AccessDeniedException
* if the user doesn't have the permission.
*
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static void checkAnyPermission(AccessControlled ac, Permission[] permissions) {
if (permissions == null || permissions.length == 0) {
Expand Down
6 changes: 3 additions & 3 deletions core/src/main/java/hudson/init/InitMilestone.java
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,14 @@ public enum InitMilestone implements Milestone {

/**
* By this milestone, all the system configurations are loaded from file system
* @since TODO
* @since 2.220
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
SYSTEM_CONFIG_LOADED("System config loaded"),

/**
* By this milestone, the system configuration is adapted just in case any plugin (CasC might be an example) needs
* to update configuration files
* @since TODO
* @since 2.220
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
SYSTEM_CONFIG_ADAPTED("System config adapted"),

Expand All @@ -107,7 +107,7 @@ public enum InitMilestone implements Milestone {

/**
* By this milestone, any job configuration is adapted or updated just in case any plugin needs to update former/old configurations or init scripts
* @since TODO
* @since 2.220
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
JOB_CONFIG_ADAPTED("Configuration for all jobs updated"),

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/model/Computer.java
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,7 @@ public void doRssFailed(StaplerRequest req, StaplerResponse rsp ) throws IOExcep
* Retrieve the RSS feed for the last build for each project executed in this computer.
* Only the information from {@link AbstractProject} is displayed since there isn't a proper API to gather
* information about the node where the builds are executed for other sorts of projects such as Pipeline
* @since TODO
* @since 2.215
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@Restricted(DoNotUse.class)
public void doRssLatest( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException {
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/model/Descriptor.java
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ public String getGlobalConfigPage() {
* Override to return something different if appropriate. The only currently supported alternative return value is {@link Jenkins#MANAGE}.
*
* @return Permission required to globally configure this descriptor.
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public @Nonnull
Permission getRequiredGlobalConfigPagePermission() {
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/model/Executor.java
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ public HttpResponse doStop() {
* @param runExtId
* if not null, the externalizable id ({@link Run#getExternalizableId()})
* of the build the user expects to interrupt
* @since TODO
* @since 2.209
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@RequirePOST
@Restricted(NoExternalUse.class)
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/model/Fingerprint.java
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,7 @@ void save(File file) throws IOException {
/**
* Returns a facet that blocks the deletion of the fingerprint.
* Returns null if no such facet.
* @since TODO
* @since 2.223
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public @CheckForNull FingerprintFacet getFacetBlockingDeletion() {
for (FingerprintFacet facet : facets) {
Expand Down
10 changes: 5 additions & 5 deletions core/src/main/java/hudson/model/ItemGroup.java
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public interface ItemGroup<T extends Item> extends PersistenceRoot, ModelObject
/**
* Gets all the items in this collection in a read-only view
* that matches supplied Predicate
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default Collection<T> getItems(Predicate<T> pred) {
return getItemsStream(pred)
Expand All @@ -71,7 +71,7 @@ default Collection<T> getItems(Predicate<T> pred) {

/**
* Gets a read-only stream of all the items in this collection
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default Stream<T> getItemsStream() {
return getItems().stream();
Expand All @@ -80,7 +80,7 @@ default Stream<T> getItemsStream() {
/**
* Gets a read-only stream of all the items in this collection
* that matches supplied Predicate
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default Stream<T> getItemsStream(Predicate<T> pred) {
return getItemsStream().filter(pred);
Expand Down Expand Up @@ -132,7 +132,7 @@ default <T extends Item> List<T> getAllItems(Class<T> type) {

/**
* Similar to {@link #getAllItems(Class)} with additional predicate filtering
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default <T extends Item> List<T> getAllItems(Class<T> type, Predicate<T> pred) {
return Items.getAllItems(this, type, pred);
Expand All @@ -150,7 +150,7 @@ default <T extends Item> Iterable<T> allItems(Class<T> type) {
/**
* Gets all the {@link Item}s unordered, lazily and recursively in the {@link ItemGroup} tree
* and filter them by the given type and given predicate
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default <T extends Item> Iterable<T> allItems(Class<T> type, Predicate<T> pred) {
return Items.allItems(this, type, pred);
Expand Down
6 changes: 3 additions & 3 deletions core/src/main/java/hudson/model/Items.java
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ public static <T extends Item> List<T> getAllItems(final ItemGroup root, Class<T
* @param pred Predicate condition to filter items
* @return List of items matching given criteria
*
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static <T extends Item> List<T> getAllItems(final ItemGroup root, Class<T> type, Predicate<T> pred) {
List<T> r = new ArrayList<>();
Expand Down Expand Up @@ -466,7 +466,7 @@ public static <T extends Item> Iterable<T> allItems(ItemGroup root, Class<T> typ
* @param <T> the type.
* @param <T> the predicate.
* @return An {@link Iterable} for all items.
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static <T extends Item> Iterable<T> allItems(ItemGroup root, Class<T> type, Predicate<T> pred) {
return allItems(Jenkins.getAuthentication(), root, type, pred);
Expand Down Expand Up @@ -502,7 +502,7 @@ public static <T extends Item> Iterable<T> allItems(Authentication authenticatio
* @param <T> the type.
* @param pred the predicate.
* @return An {@link Iterable} for all items.
* @since TODO
* @since 2.221
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static <T extends Item> Iterable<T> allItems(Authentication authentication, ItemGroup root, Class<T> type, Predicate<T> pred) {
return new AllItemsIterable<>(root, authentication, type, pred);
Expand Down
6 changes: 3 additions & 3 deletions core/src/main/java/hudson/model/ManagementLink.java
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public boolean getRequiresPOST() {
* when this was introduced can define a category. Plugins with newer core dependency override {@link #getCategory()} instead.
*
* @return name of the desired category, one of the enum values of {@link Category}, e.g. {@code STATUS}.
* @since TODO
* @since 2.226
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@Restricted(NoExternalUse.class) // TODO I don't think this works
protected @Nonnull String getCategoryName() {
Expand All @@ -154,7 +154,7 @@ public boolean getRequiresPOST() {
* Category for management link, uses {@code String} so it can be done with core dependency pre-dating the version this feature was added.
*
* @return An enum value of {@link Category}.
* @since TODO
* @since 2.226
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public @Nonnull Category getCategory() {
try {
Expand All @@ -168,7 +168,7 @@ public boolean getRequiresPOST() {
/**
* Categories supported by this version of core.
*
* @since TODO
* @since 2.226
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public enum Category {
CONFIGURATION(Messages._ManagementLink_Category_CONFIGURATION()),
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/hudson/model/RSS.java
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public static <E> void forwardToRss(String title, String url, Collection<? exten
* URL of the model object that owns this feed. Relative to the context root.
* @param runList
* Entries to be listed in the RSS feed.
* @since TODO
* @since 2.215
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static void rss(StaplerRequest req, StaplerResponse rsp, String title, String url, RunList runList) throws IOException, ServletException {
rss(req, rsp, title, url, runList, null);
Expand All @@ -98,7 +98,7 @@ public static void rss(StaplerRequest req, StaplerResponse rsp, String title, St
* Entries to be listed in the RSS feed.
* @param feedAdapter
* Controls how to render entries to RSS.
* @since TODO
* @since 2.215
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static void rss(StaplerRequest req, StaplerResponse rsp, String title, String url, RunList runList, FeedAdapter<Run> feedAdapter) throws IOException, ServletException {
final FeedAdapter<Run> feedAdapter_ = feedAdapter == null ? Run.FEED_ADAPTER : feedAdapter;
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/hudson/model/Run.java
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
* This is applied to the raw, unformatted description. Especially complex formatting
* like hyperlinks can result in much less text being shown than this might imply.
* Negative values will disable truncation, {@code 0} will enforce empty strings.
* @since TODO
* @since 2.223
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
private static /* non-final for Groovy */ int TRUNCATED_DESCRIPTION_LIMIT = SystemProperties.getInteger("historyWidget.descriptionLimit", 100);

Expand Down Expand Up @@ -992,7 +992,7 @@ protected void dropLinks() {
* @return a list with the builds (youngest build first).
* May be smaller than 'numberOfBuilds' or even empty
* if not enough builds satisfying the threshold have been found. Never null.
* @since TODO
* @since 2.202
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
protected @Nonnull List<RunT> getBuildsOverThreshold(int numberOfBuilds, @Nonnull Result threshold) {
List<RunT> builds = new ArrayList<>(numberOfBuilds);
Expand Down
8 changes: 4 additions & 4 deletions core/src/main/java/hudson/model/UpdateSite.java
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public long getDataTimestamp() {
* does not exist, or is otherwise due for update.
* Accepted formats are JSONP or HTML with {@code postMessage}, not raw JSON.
* @return null if no updates are necessary, or the future result
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public @CheckForNull Future<FormValidation> updateDirectly() {
return updateDirectly(DownloadService.signatureCheck);
Expand Down Expand Up @@ -199,7 +199,7 @@ public long getDataTimestamp() {
/**
* Forces an update of the data file from the configured URL, irrespective of the last time the data was retrieved.
* @return A {@code FormValidation} indicating the if the update metadata was successfully downloaded from the configured update site
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* @throws IOException if there was an error downloading or saving the file.
*/
public @Nonnull FormValidation updateDirectlyNow() throws IOException {
Expand Down Expand Up @@ -1023,7 +1023,7 @@ public final class Plugin extends Entry {

/**
* Date when this plugin was released.
* @since TODO
* @since 2.224
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@Exported
public final Date releaseTimestamp;
Expand Down Expand Up @@ -1325,7 +1325,7 @@ public boolean fixesSecurityVulnerabilities() {
/**
* Get the list of incompatible dependencies (if there are any, as determined by isNeededDependenciesCompatibleWithInstalledVersion)
*
* @since TODO
* @since 2.203
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@Restricted(NoExternalUse.class) // table.jelly
@SuppressWarnings("unchecked")
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/security/ACL.java
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public final void checkPermission(@Nonnull Permission p) {
* @throws IllegalArgumentException
* if no permissions are provided
*
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public final void checkAnyPermission(@Nonnull Permission... permissions) {
if (permissions.length == 0) {
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/hudson/security/AccessControlled.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ default void checkPermission(@Nonnull Permission permission) throws AccessDenied
* Convenient short-cut for {@code getACL().checkAnyPermission(permission)}
* @see ACL#checkAnyPermission(Permission...)
*
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default void checkAnyPermission(@Nonnull Permission... permission) throws AccessDeniedException {
getACL().checkAnyPermission(permission);
Expand All @@ -68,7 +68,7 @@ default boolean hasPermission(@Nonnull Permission permission) {
* Convenient short-cut for {@code getACL().hasAnyPermission(permission)}
* @see ACL#hasAnyPermission(Permission...)
*
* @since TODO
* @since 2.222
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
default boolean hasAnyPermission(@Nonnull Permission... permission) {
return getACL().hasAnyPermission(permission);
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/hudson/slaves/JNLPLauncher.java
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,14 @@ public boolean isLaunchSupported() {
}

/**
* @since TODO
* @since 2.216
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public boolean isWebSocket() {
return webSocket;
}

/**
* @since TODO
* @since 2.216
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@DataBoundSetter
public void setWebSocket(boolean webSocket) {
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/hudson/triggers/SafeTimerTask.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public abstract class SafeTimerTask extends TimerTask {

/**
* Lambda-friendly means of creating a task.
* @since TODO
* @since 2.216
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public static SafeTimerTask of(ExceptionRunnable r) {
return new SafeTimerTask() {
Expand All @@ -64,7 +64,7 @@ protected void doRun() throws Exception {
}
/**
* @see #of
* @since TODO
* @since 2.216
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
@FunctionalInterface
public interface ExceptionRunnable {
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/jenkins/model/FingerprintFacet.java
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public long getTimestamp() {
/**
* Returns whether Fingerprint deletion has been blocked by this Facet.
* Returns false by default. Override the default to block the deletion of the associated Fingerprint.
* @since TODO
* @since 2.223
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*/
public boolean isFingerprintDeletionBlocked() {
return false;
Expand Down
Loading