-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ConnPlotter code from NEST to a separate repository #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. I'm wondering a bit if the toplevel Python files (other than setup.py
, that is) should go into their own src
or nest-connplotter
directory instead of being toplevel.
I'd also like to hear @heplesser's feedback as original author before merging
And I think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This move is fine with me. "examples" is currently set up as a package, thus examples/__init__.py
. But having it as a package does not really make sense, so the __init__.py
should be removed. This has consequences:
connplotter_tutorial.py
relies on examples being a package, but that should be easily fixed.- Also
setup.py
treats examples as a package and needs to be adjusted to ensure that the examples will be installed.
Finally, the tutorial is in a very outdated literal programming format, it would be great to convert it to a notebook or our standard style for examples.
Removed I am trying to run the tutorial locally on my machine and it is taking a long time to run. I will investigate what is taking time. @heplesser When you say |
Oh I think I did some duplicate things in #2. Some things that should be taken from there:
|
Work and discussion continues in #2. |
Co-authored-by: Pooja Babu <[email protected]>
Fixes #1971
This PR moves all the files related to
ConnPlotter
fromnest-simulator
repo.