-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brushed up the source code #2
Conversation
* Moved to `setuptools`, away from deprecated `distutils`. * Removed unconventional packaging of an examples folder. * Added install requirements.
* Moved stuff to root folder instead of `extras` folder * Removed `package_dir` from setup * Fixed `matplotlib.font_manager` import error
Thanks for this contribution! Can you please quickly comment in how far this complements of conflicts with #1? At least the move of files seems to be incompatible. |
It seems that #1 places the files in the root folder, I wouldn't do that. It's more conventional for Python projects to gather their source code in a folder named after the package (i.e. |
@jougs I added the missing changes from that PR here and now it can replace it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Helveg thanks for these changes! Isn't it better to have the package name as nest-connplotter
instead of ConnPlotter
?
Both names are available on PyPI. Using |
I have no strong opinions either way, but would like things to be somewhat consistent. Here's the current situation:
* soon in a NEST Initiative GitHub account near you. @heplesser, @terhorstd: maybe we should discuss this in the next open VC? |
I can amend the commit message, is there a format I should follow, could you perhaps give me the exact string to amend? |
Adding |
@jougs @terhorstd Putting the naming onto the agenda of the nest Open VC is a good idea. |
👍 Added as discussion point to the next meeting. |
Co-authored-by: Pooja Babu <[email protected]>
The naming discussion in the Open NEST video conference today resulted in the creation of nest/nest-simulator#2161 and the decision to rename this repository from These steps should now allow to also name the PyPI package and the module the same way as the repository. @Helveg: could you please update this PR accordingly? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion.
When merging this one, nest/nest-simulator#2147 should also be merged. |
Co-authored-by: Jochen Martin Eppler <[email protected]>
Maintainer can now
python setup.py bdist_wheel
to make a functional wheel.