Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConnPlotter from the NEST code base #2147

Merged
merged 8 commits into from
Dec 15, 2021
Merged

Remove ConnPlotter from the NEST code base #2147

merged 8 commits into from
Dec 15, 2021

Conversation

pnbabu
Copy link
Contributor

@pnbabu pnbabu commented Sep 1, 2021

Fixes #1971

This PR removes the files related to ConnPlotter and are now moved to a new repository nest-connplotter.

The PR in the nest-connplotter repo with the initial changes - nest/connplotter#1

@jougs jougs requested review from jougs and heplesser September 2, 2021 08:02
@jougs jougs added I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Sep 2, 2021
@jougs jougs added this to the NEST 3.1 milestone Sep 2, 2021
jougs
jougs approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

heplesser
heplesser requested changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in principle, but I would not want to merge this before connplotter#1 is merged, so the ConnPlotter remains available at all times. Also, assuming that this will go into 3.1, the 3.0->3.1 transition guide should mention where ConnPlotter can now be found.

@heplesser heplesser modified the milestones: NEST 3.1, NEST 3.2 Sep 3, 2021
@jougs
Copy link
Contributor

jougs commented Sep 17, 2021

@pnbabu: can you please add a file doc/userdoc/release_notes/v3.2/index.rst along the lines of the 3.1 release notes and mention the move there as @heplesser suggested? Thanks!

@jougs jougs mentioned this pull request Sep 17, 2021
Merged
@jougs
Copy link
Contributor

jougs commented Nov 12, 2021

@pnbabu: friendly ping!

@jougs
Copy link
Contributor

jougs commented Nov 15, 2021

@poojanbabu: You can re-use the introductory text from my 3.2 release notes from #2208 for this one. If you're quick, I'll get to deal with the merge conflicts 😉

@Helveg Helveg mentioned this pull request Nov 26, 2021
Merged
@clinssen
Copy link
Contributor

Can we link to the new repository from the documentation somewhere?

@jougs
Copy link
Contributor

jougs commented Dec 2, 2021

@pnbabu: the merge of #2200 apparently got you some conflicts. Can you please update. Thanks!

@pnbabu pnbabu requested a review from jougs December 2, 2021 12:34
@jougs
Copy link
Contributor

jougs commented Dec 2, 2021

@pnbabu: thanks for the update!

I think @clinssen is right. Can you maybe add a link to the related projects page and possibly also a paragraph with one image or so to the end of the connection management guide? You could also coordinate with @jessica-mitchell, who is anyway currently restructuring the guides and pages. Thanks!

@pnbabu
Copy link
Contributor Author

pnbabu commented Dec 9, 2021

@jougs I have added conplotter repository details to the related projects page. It turns out that the existing example file in the connplotter repository is buggy and fixing it is taking longer than I expected. So I suggest we go ahead merging this PR and I will add the details to the connection management guide in a separate PR once I fix the bugs and have some figures.

jougs
jougs approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnbabu: thanks for the updates. I think your proposal sounds very reasonable.

@jougs jougs requested a review from heplesser December 13, 2021 20:40
heplesser
heplesser approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnbabu Thank you for taking care of this!

@heplesser heplesser merged commit 83f18e2 into nest:master Dec 15, 2021
@jougs jougs changed the title Remove Connplotter from the NEST code base Remove ConnPlotter from the NEST code base Jan 21, 2022
Helveg added a commit to Helveg/nest-simulator that referenced this pull request Jun 6, 2022
@Helveg
Merge pull request nest#2147 from pnbabu/rm-connplotter
70f7e94 
Remove Connplotter from the NEST code base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs jougs approved these changes

Assignees

@pnbabu pnbabu

Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
NEST 3.2
Development

Successfully merging this pull request may close these issues.

Move ConnPlotter from NEST code base to separate package
4 participants
@pnbabu @jougs @clinssen @heplesser