-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ConnPlotter
from the NEST code base
#2147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine in principle, but I would not want to merge this before connplotter#1 is merged, so the ConnPlotter remains available at all times. Also, assuming that this will go into 3.1, the 3.0->3.1 transition guide should mention where ConnPlotter can now be found.
@pnbabu: can you please add a file |
@pnbabu: friendly ping! |
@poojanbabu: You can re-use the introductory text from my 3.2 release notes from #2208 for this one. If you're quick, I'll get to deal with the merge conflicts 😉 |
Can we link to the new repository from the documentation somewhere? |
@pnbabu: thanks for the update! I think @clinssen is right. Can you maybe add a link to the related projects page and possibly also a paragraph with one image or so to the end of the connection management guide? You could also coordinate with @jessica-mitchell, who is anyway currently restructuring the guides and pages. Thanks! |
@jougs I have added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnbabu: thanks for the updates. I think your proposal sounds very reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnbabu Thank you for taking care of this!
ConnPlotter
from the NEST code base
Remove Connplotter from the NEST code base
Fixes #1971
This PR removes the files related to
ConnPlotter
and are now moved to a new repository nest-connplotter.The PR in the
nest-connplotter
repo with the initial changes - nest/connplotter#1