Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Case 1) Remove .json files runtimes from DS notebook & removed the COPY instruction of them on the Dockerfile #943

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 10, 2025

Remove .json files runtimes from DS notebook & removed the COPY instruction of them on the Dockerfile.

Related to: https://issues.redhat.com/browse/RHOAIENG-20241

Description

SUPER IMPORTANT NOTE:
Case 1: This PR should be merged only if the corresponding PR: opendatahub-io/kubeflow#513 on notebook-controller is been merged.
Case 2: If the PR on notebook-controller is not merged, should revert the COPY cmd on DS dockerfile deleted by mistake PR: #944

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr March 10, 2025 11:10
Copy link
Contributor

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/m label Mar 10, 2025
@atheo89
Copy link
Member Author

atheo89 commented Mar 10, 2025

/hold
Keep this PR on hold till the corresponding one on odh-notebook-controller is merged.

Copy link
Contributor

openshift-ci bot commented Mar 10, 2025

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-rocm-jupyter-pt-ubi9-python-3-11-pr-image-mirror c6d6421 link true /test notebook-rocm-jupyter-pt-ubi9-python-3-11-pr-image-mirror
ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror c6d6421 link true /test notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
ci/prow/notebooks-ubi9-e2e-tests c6d6421 link true /test notebooks-ubi9-e2e-tests
ci/prow/rocm-notebooks-e2e-tests c6d6421 link true /test rocm-notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant