(case 2) Add the runtime-images COPY cmd back on DS notebook #944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this comment: #909 (comment)
Description
This line removed while I was working on the https://issues.redhat.com/browse/RHOAIENG-20241.
So in case that we are not ready to incorporate the generation of pipeline-runtime-images config map via the odh-notebook-controller, we should keep still funtional the old logic of the runtimes, if not we are fine without this PR as a follow up is been created to clean up the notebooks from the old structure: #943.
❗ SUPER IMPORTANT NOTE: ❗
Case 1: If the corresponding PR: opendatahub-io/kubeflow#513 on notebook-controller is been merged, this PR should be merged as well #943
Case 2: If the PR on notebook-controller is not merged, should revert the COPY cmd on DS dockerfile deleted by mistake by this PR.
How Has This Been Tested?
GHA builds
Merge criteria: