Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(case 2) Add the runtime-images COPY cmd back on DS notebook #944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 10, 2025

Fix this comment: #909 (comment)

Description

This line removed while I was working on the https://issues.redhat.com/browse/RHOAIENG-20241.
So in case that we are not ready to incorporate the generation of pipeline-runtime-images config map via the odh-notebook-controller, we should keep still funtional the old logic of the runtimes, if not we are fine without this PR as a follow up is been created to clean up the notebooks from the old structure: #943.

❗ SUPER IMPORTANT NOTE: ❗
Case 1: If the corresponding PR: opendatahub-io/kubeflow#513 on notebook-controller is been merged, this PR should be merged as well #943
Case 2: If the PR on notebook-controller is not merged, should revert the COPY cmd on DS dockerfile deleted by mistake by this PR.

How Has This Been Tested?

GHA builds

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jiridanek and jstourac March 10, 2025 11:20
Copy link
Contributor

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 10, 2025

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-ubi9-e2e-tests 6329621 link true /test notebooks-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant