Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger Tracing ] In Jaeger Tracing properties shown in span tags Before mediation and after mediation are same #5215

Closed
malakaganga opened this issue Jul 29, 2020 · 0 comments · Fixed by wso2/wso2-synapse#1617
Assignees

Comments

@malakaganga
Copy link
Contributor

Description:

In Jaeger Tracing span tags Before mediation and after mediation are the same.

If we put a payload factory mediator and change the payload, in span tags of PayloadFactoryMediator it shows the same payload as the beforePayload tag and afterPayload tag.

Affected Product Version:
EI-6.6.0

OS, DB, other environment details and versions:

Steps to reproduce:
Set up EI with open tracing
And Add the following api

<?xml version="1.0" encoding="UTF-8"?>
<api xmlns="http://ws.apache.org/ns/synapse"
     name="stock"
     context="/stock" trace="enable">
   <resource methods="POST">
      <inSequence>
         <payloadFactory media-type="xml">
           <format>
             <testClone xmlns="">
               <test>test payload without calling</test>
             </testClone>
           </format>
         </payloadFactory>
         <respond/>
      </inSequence>
   </resource>
</api>

Send a request and monitor Span Tags of PayloadFactoryMediator the beforePayload tag and afterPayload tag will shown as same.

@malakaganga malakaganga self-assigned this Jul 29, 2020
malakaganga added a commit to malakaganga/wso2-synapse that referenced this issue Aug 5, 2020
In Jaeger Tracing span tags Before mediation and after mediation are the same.
If we put a payload factory mediator and change the payload, in span tags
of PayloadFactoryMediator it shows the same payload for beforePayload tag
and the afterPayload tag.
Fix this issue by changing the design of close event handling.

Also Currently, in EI Jager tracing, we can only see the property name.
This commit improves the code to add the property value as well.

Fixes: wso2/product-ei#5218
Fixes: wso2/product-ei#5215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant