Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property values to the Jaeger tracing #5218

Closed
malakaganga opened this issue Jul 30, 2020 · 0 comments · Fixed by wso2/wso2-synapse#1617
Closed

Add property values to the Jaeger tracing #5218

malakaganga opened this issue Jul 30, 2020 · 0 comments · Fixed by wso2/wso2-synapse#1617
Assignees
@malakaganga
Labels
Version/6.6.0

Comments

@malakaganga
Copy link
Contributor

Description:
Currently, in EI Jager tracing, we can only see the property name. We should improve the code to add the property value also.

Here if the property mediator scope is given as trace

<property name="CHARACTER_SET_ENCODING" value="ISO-8859-1" scope="trace" type="STRING"/>

The Value of Property should be added as propertyValue Span Tag in tracing
@malakaganga malakaganga self-assigned this Jul 30, 2020
@malakaganga malakaganga mentioned this issue Aug 4, 2020
Closed
malakaganga added a commit to malakaganga/wso2-synapse that referenced this issue Aug 5, 2020
@malakaganga
Add property values to the Jaeger tracing
f895419 
In Jaeger Tracing span tags Before mediation and after mediation are the same.
If we put a payload factory mediator and change the payload, in span tags
of PayloadFactoryMediator it shows the same payload for beforePayload tag
and the afterPayload tag.
Fix this issue by changing the design of close event handling.

Also Currently, in EI Jager tracing, we can only see the property name.
This commit improves the code to add the property value as well.

Fixes: wso2/product-ei#5218
Fixes: wso2/product-ei#5215
@malakaganga malakaganga mentioned this issue Aug 5, 2020
Merged
@GDLMadushanka GDLMadushanka mentioned this issue Jan 5, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malakaganga malakaganga

Labels
Version/6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add property values to the Jaeger tracing malakaganga/wso2-synapse
1 participant
@malakaganga