Add property values to the Jaeger tracing #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Jaeger Tracing span tags Before mediation and after mediation are the same. If we put a payload factory mediator and change the payload, in span tags of PayloadFactoryMediator it shows the same payload for beforePayload tag and the afterPayload tag. Fix this issue by changing the design of close event handling. Also Currently, in EI Jager tracing, we can only see the property name. This commit improves the code to add the property value as well. Fixes: wso2/product-ei#5218 Fixes: wso2/product-ei#5215
senthuran16
approved these changes
Aug 5, 2020
Vathsan
reviewed
Aug 6, 2020
modules/core/src/main/java/org/apache/synapse/mediators/builtin/PropertyMediator.java
Show resolved
Hide resolved
Vathsan
reviewed
Aug 6, 2020
...va/org/apache/synapse/aspects/flow/statistics/opentracing/management/helpers/SpanTagger.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In Jaeger Tracing span tags Before mediation and after mediation are the same. If we put a payload factory mediator and change the payload, in span tags of PayloadFactoryMediator it shows the same payload for beforePayload tag
and the afterPayload tag. Fix this issue by changing the design of close event handling.
Also Currently, in EI Jager tracing, we can only see the property name. This commit improves the code to add the property value as well.
Goals
Fixes: wso2/product-ei#5218
Fixes: wso2/product-ei#5215