-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Update ycmd #2804
[READY] Update ycmd #2804
Conversation
Include the following changes: - automatically find Rust sources through rustup; - do not return canonical type if identical to type in C-family languages; - improve support of system Boost and system libclang on Gentoo; - improve Red Hat and CentOS detection; - consider header file entries in compilation database; - improve completion of include statements in C-family languages; - rename completer options in installation script; - only include one macOS toolchain.
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 20 20
Lines 1954 1954
=======================================
Hits 1806 1806
Misses 148 148 |
Reviewed 3 of 3 files at r1. README.md, line 1067 at r1 (raw file):
I would add ‘to get the code’ before the colon like ‘add the following command to download he code:’ ... Comments from Reviewable |
Mention rustup to get the Rust source code.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2. README.md, line 1067 at r1 (raw file): Previously, puremourning (Ben Jackson) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 3 files at r1, 2 of 2 files at r2. Comments from Reviewable |
perfect. @zzbot r+ Reviewed 2 of 2 files at r2. Comments from Reviewable |
📌 Commit 81be23b has been approved by |
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#785: automatically find Rust sources through rustup; - PR ycm-core/ycmd#835: do not return canonical type if identical to type in C-family languages; - PR ycm-core/ycmd#837: improve support of system Boost and system libclang on Gentoo; - PR ycm-core/ycmd#840: improve Red Hat and CentOS detection; - PR ycm-core/ycmd#842: consider header file entries in compilation database; - PR ycm-core/ycmd#843: improve completion of include statements in C-family languages; - PR ycm-core/ycmd#851: rename completer options in installation script; - PR ycm-core/ycmd#855: only include one macOS toolchain. Update documentation according to PRs ycm-core/ycmd#785 and ycm-core/ycmd#851. Close #2379. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2804) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-travis |
Include the following changes:
Update documentation according to PRs ycm-core/ycmd#785 and ycm-core/ycmd#851.
Close #2379.
This change is