Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Update ycmd #2804

Merged
merged 3 commits into from
Oct 11, 2017
Merged

[READY] Update ycmd #2804

merged 3 commits into from
Oct 11, 2017

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Oct 10, 2017

Include the following changes:

Update documentation according to PRs ycm-core/ycmd#785 and ycm-core/ycmd#851.

Close #2379.


This change is Reviewable

Include the following changes:
 - automatically find Rust sources through rustup;
 - do not return canonical type if identical to type in C-family languages;
 - improve support of system Boost and system libclang on Gentoo;
 - improve Red Hat and CentOS detection;
 - consider header file entries in compilation database;
 - improve completion of include statements in C-family languages;
 - rename completer options in installation script;
 - only include one macOS toolchain.
@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #2804 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2804   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          20       20           
  Lines        1954     1954           
=======================================
  Hits         1806     1806           
  Misses        148      148

@puremourning
Copy link
Member

:lgtm: with one comment for consideration. Thanks for doing this!


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


README.md, line 1067 at r1 (raw file):

rustup component add rust-src

to get the code. YCM will find its location automatically. Otherwise, download

I would add ‘to get the code’ before the colon like ‘add the following command to download he code:’ ...


Comments from Reviewable

Mention rustup to get the Rust source code.
@micbou
Copy link
Collaborator Author

micbou commented Oct 10, 2017

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


README.md, line 1067 at r1 (raw file):

Previously, puremourning (Ben Jackson) wrote…

I would add ‘to get the code’ before the colon like ‘add the following command to download he code:’ ...

Done.


Comments from Reviewable

@bstaletic
Copy link
Collaborator

:lgtm:, but I'll let @puremourning trigger @zzbot.


Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@puremourning
Copy link
Member

perfect. @zzbot r+


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented Oct 10, 2017

📌 Commit 81be23b has been approved by puremourning

@zzbot
Copy link
Contributor

zzbot commented Oct 10, 2017

⌛ Testing commit 81be23b with merge 48e3f2c...

zzbot added a commit that referenced this pull request Oct 10, 2017
[READY] Update ycmd

Include the following changes:
 - PR ycm-core/ycmd#785: automatically find Rust sources through rustup;
 - PR ycm-core/ycmd#835: do not return canonical type if identical to type in C-family languages;
 - PR ycm-core/ycmd#837: improve support of system Boost and system libclang on Gentoo;
 - PR ycm-core/ycmd#840: improve Red Hat and CentOS detection;
 - PR ycm-core/ycmd#842: consider header file entries in compilation database;
 - PR ycm-core/ycmd#843: improve completion of include statements in C-family languages;
 - PR ycm-core/ycmd#851: rename completer options in installation script;
 - PR ycm-core/ycmd#855: only include one macOS toolchain.

Update documentation according to PRs ycm-core/ycmd#785 and ycm-core/ycmd#851.

Close #2379.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2804)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented Oct 11, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: puremourning
Pushing 48e3f2c to master...

@zzbot zzbot merged commit 81be23b into ycm-core:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants