[READY] Improve Red Hat and CentOS detection

[micbou]

Detecting that the distribution is Red Hat or CentOS by checking if the /etc/redhat-release file contains Red Hat (respectively CentOS) is more reliable than using lsb_release as this tool may not be available on a clean installation (e.g. CentOS 6.5).

Tested on CentOS 6.5 and 7.3.

---

This change is 

[codecov-io]

Codecov Report

Merging #840 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files          79       79           
  Lines        5407     5407           
  Branches      170      170           
=======================================
  Hits         5128     5128           
  Misses        231      231           
  Partials       48       48

[bstaletic]

I like the distro dependent code quite a bit more now.

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[Valloric]

with minor comment.

Thanks for the PR!

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

cpp/CMakeLists.txt, line 221 at r1 (raw file):

endif()

# Gentoo detection. Needed because Gentoo is a special snowflake that puts

This seems unrelated to the PR description. Do we know this change works?

---

Comments from Reviewable

[bstaletic]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

cpp/CMakeLists.txt, line 221 at r1 (raw file):

Previously, Valloric (Val Markovic) wrote…

This seems unrelated to the PR description. Do we know this change works?

The Gentoo part was from #837. As a Gentoo user, I can confirm that it works.

---

Comments from Reviewable

[Valloric]

@zzbot r=bstaletic

Thanks again!

---

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

cpp/CMakeLists.txt, line 221 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

The Gentoo part was from #837. As a Gentoo user, I can confirm that it works.

Thanks for confirming!

---

Comments from Reviewable

[zzbot]

📌 Commit 039b248 has been approved by bstaletic

[zzbot]

⌛ Testing commit 039b248 with merge 5ea657c...

[zzbot]

☀️ Test successful - status-appveyor, status-travis
Approved by: bstaletic
Pushing 5ea657c to master...