[READY] Rename completer options #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the completer options named after the language is much more intuitive. Users are not supposed to know about the semantic engines used by ycmd.
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 79 79
Lines 5406 5406
Branches 170 170
=======================================
Hits 5127 5127
Misses 231 231
Partials 48 48 |
|
This looks good. Reviewed 6 of 6 files at r1. Comments from Reviewable |
|
Heh, this has been bothering me for literally years, I just never found it pressing enough to fix. :D Thanks for the PR! @zzbot r=bstaletic |
|
📌 Commit 3e83285 has been approved by |
zzbot
added a commit
that referenced
this pull request
Oct 4, 2017
[READY] Rename completer options It's more intuitive for users if completer options are named after the language and not after the semantic engine e.g. `--rust-completer` instead of `--racer-completer`. To preserve backward compatibility, we keep the old options but deprecate them by hiding them from the `--help` output. We don't rename `--clang-completer` since `clang` is really well known and an appropriate name to designate C-family languages. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/851) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
zzbot
added a commit
to ycm-core/YouCompleteMe
that referenced
this pull request
Oct 10, 2017
[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#785: automatically find Rust sources through rustup; - PR ycm-core/ycmd#835: do not return canonical type if identical to type in C-family languages; - PR ycm-core/ycmd#837: improve support of system Boost and system libclang on Gentoo; - PR ycm-core/ycmd#840: improve Red Hat and CentOS detection; - PR ycm-core/ycmd#842: consider header file entries in compilation database; - PR ycm-core/ycmd#843: improve completion of include statements in C-family languages; - PR ycm-core/ycmd#851: rename completer options in installation script; - PR ycm-core/ycmd#855: only include one macOS toolchain. Update documentation according to PRs ycm-core/ycmd#785 and ycm-core/ycmd#851. Close #2379. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2804) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more intuitive for users if completer options are named after the language and not after the semantic engine e.g.
--rust-completerinstead of--racer-completer. To preserve backward compatibility, we keep the old options but deprecate them by hiding them from the--helpoutput. We don't rename--clang-completersinceclangis really well known and an appropriate name to designate C-family languages.This change is