Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] use whisper to format vtt subtitle #1187

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ptitloup
Copy link
Contributor

Before sending your pull request, make sure the following are done

  • You have read our contribution guidelines.
  • Your PR targets the develop branch.
  • The title of your PR starts with [WIP] or [DONE].

@ptitloup ptitloup changed the title [WIP] use whipser to format vtt subtitle [DONE] use whipser to format vtt subtitle Aug 20, 2024
@ptitloup ptitloup self-assigned this Aug 20, 2024
@ptitloup ptitloup added the enhancement New feature or request label Aug 20, 2024
Copy link
Collaborator

@LoicBonavent LoicBonavent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste une petite faute sur le titre de la PR (whipser au lieu de whisper) :) , sinon nickel

@ptitloup ptitloup changed the title [DONE] use whipser to format vtt subtitle [DONE] use whisper to format vtt subtitle Aug 20, 2024
@Badatos Badatos merged commit 8ec2846 into develop Aug 23, 2024
1 of 2 checks passed
@Badatos Badatos deleted the ptitloup/add_whisper_wordoptions branch August 23, 2024 08:29
Badatos added a commit that referenced this pull request Oct 29, 2024
## New functionalities:
* Use Whisper to format vtt subtitle (#1187)
* Remove BBB module and add sipmediagw feature (#1190)
* Add NOTIFY_SENDER boolean parameter (#1192)
* Add fields to recording rest response (#1193)
* Add return thumbnail url,width and height to oembed (#1194)
* Add optional proxy URL for request coming from Aristote (#1218)

## Bugs corrected:
* Change all filter_fields = () in filterset_fields = [], as filter_fields is deprecated  (#1191)
* Fix multi carousel (#1200)
* Change regroup videos by theme when ORGANIZE_BY_THEME = True (#1203)
* Bug habillage (#1211)
* Fix migration script for BBB (#1214)
* Improve RSS Feeds (#1215)
* Fix BBB meeting deletion link (issue #1216)
* No crop on thumbnail (#1217)
* Use `get_thumbnail` to serve video thumbnail via caching system, to prevent video folder url to be publicly available (#1221)
* Addition of a toolbar in the theme description editor of a chain. (issue #1185)
* Correction enabling channels and themes to be assigned to a set of videos (issue #1106)
* Manage restricted video access right in playlist

## Accessibility improvements: (#1219)
* Modify some redundant title strings, adding the targeted object
* Remove some redundant titles
* Correct i18n strings
* Correct duplicated id
* Remove broken aria-label id
* Add flatpage title in h1 for accessibility + remove H1 title in legal notice and accessibility statement pages

## Quality of Code:
* Minor code formatting
* Add missing DocStrings
* Upgrade GitGuardian config version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants