[DONE] Add optionnal proxy URL for request coming from Aristote #1218
+43
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badatos
reviewed
Oct 15, 2024
|
Je pense qu'il faudrait remplacer comming par coming, et de [WIP] en [DONE], non ? |
gcondess
changed the title
There was a problem hiding this comment.
Juste la traduction :
"URL of proxy server for request coming from Aristote.",
"Example: 'https://proxy_aristote.univ.fr'"
Badatos
approved these changes
Oct 15, 2024
|
Reste la faute de frappe à corriger dans le json et on pourra fusionner ;) |
Badatos
added a commit
that referenced
this pull request
Oct 29, 2024
## New functionalities: * Use Whisper to format vtt subtitle (#1187) * Remove BBB module and add sipmediagw feature (#1190) * Add NOTIFY_SENDER boolean parameter (#1192) * Add fields to recording rest response (#1193) * Add return thumbnail url,width and height to oembed (#1194) * Add optional proxy URL for request coming from Aristote (#1218) ## Bugs corrected: * Change all filter_fields = () in filterset_fields = [], as filter_fields is deprecated (#1191) * Fix multi carousel (#1200) * Change regroup videos by theme when ORGANIZE_BY_THEME = True (#1203) * Bug habillage (#1211) * Fix migration script for BBB (#1214) * Improve RSS Feeds (#1215) * Fix BBB meeting deletion link (issue #1216) * No crop on thumbnail (#1217) * Use `get_thumbnail` to serve video thumbnail via caching system, to prevent video folder url to be publicly available (#1221) * Addition of a toolbar in the theme description editor of a chain. (issue #1185) * Correction enabling channels and themes to be assigned to a set of videos (issue #1106) * Manage restricted video access right in playlist ## Accessibility improvements: (#1219) * Modify some redundant title strings, adding the targeted object * Remove some redundant titles * Correct i18n strings * Correct duplicated id * Remove broken aria-label id * Add flatpage title in h1 for accessibility + remove H1 title in legal notice and accessibility statement pages ## Quality of Code: * Minor code formatting * Add missing DocStrings * Upgrade GitGuardian config version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aristote IA as an infrastructure based on Kubernetes in order to automaticaly générate or delete backends servers adaptatively to the current load.
Those backends servers are directly requesting the POD server : Once to retrieve the URL of the audio file (witch is the base data for the IA treatment) and in second time to notify POD that the treatment is achieved.
So if the POD server not accessible from the all the WWW, the Aristote backend's will not be able to retrieve the audio file for treatment. That can be a problem on POD test servers that are not open to all the web for security reasons.
This code allow to specify a proxy URL (accessible from all the web) in order to catch Aristote backend's requests and redirect them to the POD test server (via the internal institution network)