Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] add NOTIFY_SENDER boolean parameter #1192

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

MichelAimar
Copy link
Collaborator

Ajoute un paramètre booleen NOTIFY_SENDER qui permet de choisir si la personne qui utilise le formulaire de contact reçoit une copie du message qu'elle envoie ou non. En effet, malgré le captcha, le formulaire peut être (et l'est chez nous) utilisé pour envoyer du Spam par des personnes mal intentionnées.

@Badatos
Copy link
Collaborator

Badatos commented Aug 28, 2024

Chaque paramètre doit avoir son entrée définie dans le fichier pod/main/configuration.json de manière à générer correctement la doc.

@MichelAimar
Copy link
Collaborator Author

MichelAimar commented Aug 28, 2024

Ah je ne connaissait pas, voila, ça devrait être bon. J'ai mis à partir de la version 3.8.2.

@MichelAimar
Copy link
Collaborator Author

Voila, j'ai corrigé les espaces. C'est possible de relancer les tests ?

@Badatos
Copy link
Collaborator

Badatos commented Aug 30, 2024

les tests vont de toute facon bloquer à cause du bug corrigé dans la PR #1189 que personne n'a encore pris le temps de relire ;)

@Badatos
Copy link
Collaborator

Badatos commented Aug 30, 2024

et visiblement, il y a toujours des espaces en trop dans views.py

./pod/main/views.py:291:1: W293 blank line contains whitespace
./pod/main/views.py:304:1: W293 blank line contains whitespace

@MichelAimar
Copy link
Collaborator Author

HiHan, je m'étais trompé de branche ... Trop de PR en même temps ...

@Badatos Badatos self-requested a review September 18, 2024 07:57
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK pour moi :)

Copy link
Collaborator

@gcondess gcondess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAS

@Badatos Badatos merged commit 5cb935d into EsupPortail:develop Sep 23, 2024
3 checks passed
Badatos added a commit that referenced this pull request Oct 29, 2024
## New functionalities:
* Use Whisper to format vtt subtitle (#1187)
* Remove BBB module and add sipmediagw feature (#1190)
* Add NOTIFY_SENDER boolean parameter (#1192)
* Add fields to recording rest response (#1193)
* Add return thumbnail url,width and height to oembed (#1194)
* Add optional proxy URL for request coming from Aristote (#1218)

## Bugs corrected:
* Change all filter_fields = () in filterset_fields = [], as filter_fields is deprecated  (#1191)
* Fix multi carousel (#1200)
* Change regroup videos by theme when ORGANIZE_BY_THEME = True (#1203)
* Bug habillage (#1211)
* Fix migration script for BBB (#1214)
* Improve RSS Feeds (#1215)
* Fix BBB meeting deletion link (issue #1216)
* No crop on thumbnail (#1217)
* Use `get_thumbnail` to serve video thumbnail via caching system, to prevent video folder url to be publicly available (#1221)
* Addition of a toolbar in the theme description editor of a chain. (issue #1185)
* Correction enabling channels and themes to be assigned to a set of videos (issue #1106)
* Manage restricted video access right in playlist

## Accessibility improvements: (#1219)
* Modify some redundant title strings, adding the targeted object
* Remove some redundant titles
* Correct i18n strings
* Correct duplicated id
* Remove broken aria-label id
* Add flatpage title in h1 for accessibility + remove H1 title in legal notice and accessibility statement pages

## Quality of Code:
* Minor code formatting
* Add missing DocStrings
* Upgrade GitGuardian config version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants