-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONE] Remove BBB module and add sipmediagw feature #1190
Merged
Badatos
merged 21 commits into
EsupPortail:develop
from
LoicBonavent:LoicBonavent/remove_bbb_module_and_add_sipmediagw_feature
Oct 3, 2024
Merged
[DONE] Remove BBB module and add sipmediagw feature #1190
Badatos
merged 21 commits into
EsupPortail:develop
from
LoicBonavent:LoicBonavent/remove_bbb_module_and_add_sipmediagw_feature
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LoicBonavent
commented
Aug 26, 2024
- Removal of the old BBB module (replaced by the meetings module)
- Delete MEETING_WEBINAR_SIPMEDIAGW_URL and MEETING_WEBINAR_SIPMEDIAGW_TOKEN parameters management (replaced by live gateway feature)
- Add sipmediagw_server_url and sipmediagw_server_password to live gateway class (meeting/models.py)
- Manage request URLs from SIPMediaGW server (hashkey with a / before the last 10 characters)
…ING_WEBINAR_SIPMEDIAGW_TOKEN (replaced by live gateway) parameters
…AGW_TOKEN parameters (replaced by live gateway)
…he last 10 characters)
Badatos
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci Loic,
Voila un sacré ménage de fait ;)
fanfounet
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code très propre, bien documenté !
Badatos
added a commit
that referenced
this pull request
Oct 29, 2024
## New functionalities: * Use Whisper to format vtt subtitle (#1187) * Remove BBB module and add sipmediagw feature (#1190) * Add NOTIFY_SENDER boolean parameter (#1192) * Add fields to recording rest response (#1193) * Add return thumbnail url,width and height to oembed (#1194) * Add optional proxy URL for request coming from Aristote (#1218) ## Bugs corrected: * Change all filter_fields = () in filterset_fields = [], as filter_fields is deprecated (#1191) * Fix multi carousel (#1200) * Change regroup videos by theme when ORGANIZE_BY_THEME = True (#1203) * Bug habillage (#1211) * Fix migration script for BBB (#1214) * Improve RSS Feeds (#1215) * Fix BBB meeting deletion link (issue #1216) * No crop on thumbnail (#1217) * Use `get_thumbnail` to serve video thumbnail via caching system, to prevent video folder url to be publicly available (#1221) * Addition of a toolbar in the theme description editor of a chain. (issue #1185) * Correction enabling channels and themes to be assigned to a set of videos (issue #1106) * Manage restricted video access right in playlist ## Accessibility improvements: (#1219) * Modify some redundant title strings, adding the targeted object * Remove some redundant titles * Correct i18n strings * Correct duplicated id * Remove broken aria-label id * Add flatpage title in h1 for accessibility + remove H1 title in legal notice and accessibility statement pages ## Quality of Code: * Minor code formatting * Add missing DocStrings * Upgrade GitGuardian config version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.