Merge Develop branch to ADE 1.3 release #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added managementTag and name
- renames some birth status parameters - added optional tagging date
Changes for parturition event with new progeny details closes #214
created url, and collection - resource for the time being a copy of conformation scores (work in progress)
got an error - don't know if this will help
Add CoatColorDetails in IcarAnimalCoreResource. Resolves #240
Fixed declaration for nullable reference types
HealthStatus for IcarAnimalCoreResource
Added the new messages (resources) planned or delivered for ADE 1.3.
Add severity and disease stage to icarDiagnosisResource. Resolves #297.
changed to "type": "number", "format": "double", as "double" is not a valid JSON Schema type. Discovered from Speccy validation error in PR #330
Correct required clause names for startDate --> dateFrom and endDate --> dateTo, to match the property names.
Add icarGroupWeightEventResource, icarIndividualWeightType, and icarGroupWeightEventCollection. Resolves #332
Add icarGroupTreatmentEventCollection.json and put group health treatments into healthURLScheme.json
InventoryClassification birth period previously specified the birth period as an (RFC3339) icarDateType. But in fact, per the description it is an ISO8601 interval. Changed the type to string, and added a pattern which matches a simple ISO8601 date interval (no time component) and the year and month options as per the description.
Tightened the regex to make it clearer that dates are intended (as per description) but this is not perfect, its just simple and fast.
Update icarMessageType.json
Change icarStatistics value to number
Inventory classification change - fix birthPeriod validation
Add group weigh event
Add Group birth, deaths, arrivals, departures GET, POST, and batch POST methods.
Add group GET methods to exampleURLScheme.json.
We discussed and agreed that manually replicating the properties in markdown might be easy to read but would be very hard to maintain.
Replace embedded links to previous markdown files with links direct to the JSON schema files (for those who have confidence to interpret JSON schema). Not a long term solution.
Documentation for group events
Tested all the links in understanding-animal-groups.md and corrected 3 broken links
Corrected 3 broken links.
Found one more broken link
Update changelog to 1.3 ahead of release.
Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog.md for details.