Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Develop branch to ADE 1.3 release #342

Merged
merged 193 commits into from
Nov 2, 2022
Merged

Merge Develop branch to ADE 1.3 release #342

merged 193 commits into from
Nov 2, 2022

Conversation

cookeac
Copy link
Collaborator

@cookeac cookeac commented Nov 2, 2022

See changelog.md for details.

ahokkonen and others added 30 commits August 24, 2021 21:07
- added new type for parturition progeny details
- added new common enumeration for parturition progeny status
- added managementTag and name
- renames some birth status parameters
- added optional tagging date
Changes for parturition event with new progeny details
closes #214
created url, and collection - resource for the time being a copy of conformation scores (work in progress)
got an error - don't know if this will help
Add CoatColorDetails in IcarAnimalCoreResource. Resolves #240
Fixed declaration for nullable reference types
HealthStatus for IcarAnimalCoreResource
erwinspeybroeck and others added 29 commits September 22, 2022 12:55
Added the new messages (resources) planned or delivered for ADE 1.3.
Add severity and disease stage to icarDiagnosisResource. Resolves #297.
changed to "type": "number", "format": "double", as "double" is not a valid JSON Schema type.
Discovered from Speccy validation error in PR #330
Correct required clause names for startDate --> dateFrom and endDate --> dateTo, to match the property names.
Add icarGroupWeightEventResource, icarIndividualWeightType, and icarGroupWeightEventCollection.
Resolves #332
Add icarGroupTreatmentEventCollection.json and put group health treatments into healthURLScheme.json
InventoryClassification birth period previously specified the birth period as an (RFC3339) icarDateType. But in fact, per the description it is an ISO8601 interval.
Changed the type to string, and added a pattern which matches a simple ISO8601 date interval (no time component) and the year and month options as per the description.
Tightened the regex to make it clearer that dates are intended (as per description) but this is not perfect, its just simple and fast.
Change icarStatistics value to number
Inventory classification change - fix birthPeriod validation
Add Group birth, deaths, arrivals, departures GET, POST, and batch POST methods.
Add group GET methods to exampleURLScheme.json.
Preview of documentation (much more to be done)
- Explanation of animal sets and groups (resolves #272)
- Start of ADE information model documentation (#300)
Add group events to URL Schemes. Approved at the meeting on 2022-10-20
Resolves #326
Resolves #323
We discussed and agreed that manually replicating the properties in markdown might be easy to read but would be very hard to maintain.
Replace embedded links to previous markdown files with links direct to the JSON schema files (for those who have confidence to interpret JSON schema).

Not a long term solution.
Documentation for group events
Tested all the links in understanding-animal-groups.md and corrected 3 broken links
Update changelog to 1.3 ahead of release.
@cookeac cookeac merged commit 3d1b92c into ADE-1 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants