Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proxmox support #837

Merged
merged 43 commits into from
Oct 30, 2024
Merged

Add Proxmox support #837

merged 43 commits into from
Oct 30, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Sep 2, 2024

#745 moved into our scope for uploading LFS files.

Closes #805.

otnxSl and others added 30 commits June 15, 2024 23:28
this is in regards with low-privileged user credentials
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 42 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (c97cf63) to head (bc6593b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/loaders/proxmox.py 29.26% 29 Missing ⚠️
...target/plugins/os/unix/linux/debian/proxmox/_os.py 89.04% 8 Missing ⚠️
dissect/target/plugins/child/proxmox.py 83.33% 2 Missing ⚠️
dissect/target/plugins/os/unix/_os.py 66.66% 2 Missing ⚠️
.../target/plugins/os/unix/linux/debian/proxmox/vm.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   76.87%   76.84%   -0.03%     
==========================================
  Files         318      322       +4     
  Lines       27258    27405     +147     
==========================================
+ Hits        20955    21060     +105     
- Misses       6303     6345      +42     
Flag Coverage Δ
unittests 76.84% <72.72%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from Horofic September 13, 2024 12:35
Horofic
Horofic previously approved these changes Sep 13, 2024
@Schamper Schamper merged commit c9b4aa1 into main Oct 30, 2024
16 of 20 checks passed
@Schamper Schamper deleted the add-proxmox-support branch October 30, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature/proxmox implementation PR#837
9 participants