Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTV-434 :Deprecate Autoparcel for ShippingRule.kt #1576

Merged
merged 6 commits into from
Mar 24, 2022
Merged

NTV-434 :Deprecate Autoparcel for ShippingRule.kt #1576

merged 6 commits into from
Mar 24, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Mar 23, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-03-23-220948.mp4

| --- | --- |
| | |

📋 QA

test Shipping rules for projects

Story 📖

https://kickstarter.atlassian.net/browse/NTV-434

@hadia hadia requested a review from Arkariang March 23, 2022 20:12
@hadia
Merge branch 'master' into hadia/Deprecate_Autoparcel_for_ShippingRule
39ceb7f 
# Conflicts:
#	app/src/main/java/com/kickstarter/viewmodels/BackingAddOnsFragmentViewModel.kt
@hadia hadia requested a review from leighdouglas March 23, 2022 20:15
@hadia hadia added the migration Migration Java to Kotlin label Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9ce5cef). Click here to learn what that means.
The diff coverage is 97.56%.

@@            Coverage Diff            @@
##             master    #1576   +/-   ##
=========================================
  Coverage          ?   76.55%           
  Complexity        ?     1583           
=========================================
  Files             ?      355           
  Lines             ?    14815           
  Branches          ?     1666           
=========================================
  Hits              ?    11342           
  Misses            ?     2586           
  Partials          ?      887
Impacted Files Coverage Δ
...ter/services/apiresponses/ShippingRulesEnvelope.kt 94.73% <94.73%> (ø)
...c/main/java/com/kickstarter/models/ShippingRule.kt 94.11% <96.96%> (ø)
.../kickstarter/mock/factories/ShippingRuleFactory.kt 100.00% <100.00%> (ø)
...ter/mock/factories/ShippingRulesEnvelopeFactory.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce5cef...39ceb7f. Read the comment docs.

Arkariang
Arkariang approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested backing with addons + canceling pledge afterwards

@Arkariang Arkariang merged commit 8491449 into master Mar 24, 2022
@Arkariang Arkariang deleted the hadia/Deprecate_Autoparcel_for_ShippingRule branch March 24, 2022 15:53
Arkariang added a commit that referenced this pull request Apr 6, 2022
@Arkariang
Merge branch 'master' of github.com:kickstarter/android-oss into spik…
8afc2c6 
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkariang Arkariang Arkariang approved these changes

@leighdouglas leighdouglas Awaiting requested review from leighdouglas

Assignees
No one assigned
Labels
migration Migration Java to Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadia @Arkariang