Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel #1591

Merged
merged 6 commits into from
Apr 6, 2022

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Apr 5, 2022

📲 What

🤔 Why

  • Remove all references to the AutoParcel library in Models, eventually, we will be able to remove that dependency.

👀 See

device-2022-04-05-170157.mp4

📋 QA

Test SignupBody

Story 📖

https://kickstarter.atlassian.net/browse/NTV-474

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1591 (1cbfad0) into master (0ebfd7e) will increase coverage by 0.10%.
The diff coverage is 93.15%.

@@             Coverage Diff              @@
##             master    #1591      +/-   ##
============================================
+ Coverage     77.32%   77.43%   +0.10%     
- Complexity     1638     1654      +16     
============================================
  Files           356      356              
  Lines         15135    15202      +67     
  Branches       1709     1717       +8     
============================================
+ Hits          11703    11771      +68     
+ Misses         2516     2510       -6     
- Partials        916      921       +5     
Impacted Files Coverage Δ
...com/kickstarter/services/apirequests/SignupBody.kt 92.59% <92.59%> (ø)
...kstarter/services/apirequests/ResetPasswordBody.kt 94.73% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf35604...1cbfad0. Read the comment docs.

Copy link
Contributor

@Arkariang Arkariang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Tested also some error cases

@hadia hadia merged commit 0d366bd into master Apr 6, 2022
@hadia hadia deleted the hadia/NTV-474_Migrate_SignupBody branch April 6, 2022 20:56
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants