-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel #1591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
============================================
+ Coverage 77.32% 77.43% +0.10%
- Complexity 1638 1654 +16
============================================
Files 356 356
Lines 15135 15202 +67
Branches 1709 1717 +8
============================================
+ Hits 11703 11771 +68
+ Misses 2516 2510 -6
- Partials 916 921 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Tested also some error cases
…e/NTV-411-integrate-payment-sheet * 'master' of github.com:kickstarter/android-oss: (22 commits) NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592) NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591) NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590) NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589) NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588) NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586) NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585) NTV-465: Add audio parsing (#1584) NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580) NTV-438: Deprecate autoparcel for checkout (#1583) NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578) NTV-463: Crash during regression (#1582) [no-jira]: update dependencies (#1579) NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581) NTV-441 : Migrat Video.java to kotlin and deprecate Autoparcel (#1577) NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576) NTV-456: Ktlint integration update (#1575) NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569) NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570) Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571) ...
📲 What
🤔 Why
👀 See
device-2022-04-05-170157.mp4
📋 QA
Test SignupBody
Story 📖
https://kickstarter.atlassian.net/browse/NTV-474