Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTV-463: Crash during regression #1582

Merged
merged 1 commit into from
Mar 28, 2022
Merged

NTV-463: Crash during regression #1582

merged 1 commit into from
Mar 28, 2022

Conversation

Arkariang
Copy link
Contributor

📲 What

  • Safe checkin of fragment types

🤔 Why

  • Crash

👀 See

https://console.firebase.google.com/u/1/project/android-external-release/crashlytics/app/android:com.kickstarter.kickstarter/issues/383d8df89329fd83a30a52dff0729e60?time=last-seven-days&versions=3.1.0%20(2013150884)&sessionEventKey=623E3322038000012A052F1B62946495_1657599740716809428
Screen Shot 2022-03-25 at 2 40 27 PM

| | |

📋 QA

Story 📖

NTV-463

@Arkariang Arkariang requested review from leighdouglas and hadia March 25, 2022 21:45
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1582 (64817ef) into master (315f86b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1582   +/-   ##
=========================================
  Coverage     76.65%   76.65%           
  Complexity     1599     1599           
=========================================
  Files           355      355           
  Lines         14882    14882           
  Branches       1675     1675           
=========================================
  Hits          11408    11408           
  Misses         2583     2583           
  Partials        891      891           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315f86b...64817ef. Read the comment docs.

Copy link
Contributor

@hadia hadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@Arkariang Arkariang merged commit 32b539b into master Mar 28, 2022
@Arkariang Arkariang deleted the imartin/NTV-463 branch March 28, 2022 16:13
Arkariang added a commit that referenced this pull request Mar 28, 2022
…ase-3.1.0

* 'master' of github.com:kickstarter/android-oss:
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
Arkariang added a commit that referenced this pull request Apr 6, 2022
…e/NTV-411-integrate-payment-sheet

* 'master' of github.com:kickstarter/android-oss: (22 commits)
  NTV-476 :Migrate AccessTokenEnvelope.java to kotlin and deprecate Autoparcel (#1592)
  NTV-474 :Migrate SignupBody.java to kotlin and deprecate Autoparcel (#1591)
  NTV-472 : Migrate ResetPasswordBody.java to kotlin and deprecate Autoparcel (#1590)
  NTV-436: Migrate Reftag.java to kotlin and deprecate Autoparcel (#1589)
  NTV-471 : Migrate RegisterWithFacebookBody.java to kotlin and deprecate Autoparcel (#1588)
  NTV-468 :Migrate CheckoutData.java to kotlin and deprecate Autoparcel (#1586)
  NTV-443 : Migrate LoginWithFacebookBody.java to kotlin and deprecate Autoparcel (#1585)
  NTV-465: Add audio parsing (#1584)
  NTV-437:Migrate RelativeDateTimeOptions to Kotlin and deprecate Autoparcel (#1580)
  NTV-438: Deprecate autoparcel for checkout (#1583)
  NTV-381: Migrate KSCurrency to kotlin and deprecate autoparcel (#1578)
  NTV-463: Crash during regression (#1582)
  [no-jira]: update dependencies (#1579)
  NTV-445 : Migrate ProjectNotificationBody.java to kotlin and deprecate Autoparcel (#1581)
  NTV-441  : Migrat Video.java to kotlin and deprecate Autoparcel (#1577)
  NTV-434 :Deprecate Autoparcel for ShippingRule.kt (#1576)
  NTV-456: Ktlint integration update (#1575)
  NTV-440 : Deprecate Autoparcel for ErroredBacking.kt (#1569)
  NTV-444 :Migrate MessageBody.java to kotlin and deprecate Autoparcel (#1570)
  Migrate CreatorDetails.java to kotlin and deprecate Autoparcel (#1571)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants